Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme-update #122

Merged
merged 2 commits into from
Jul 29, 2021
Merged

readme-update #122

merged 2 commits into from
Jul 29, 2021

Conversation

vivek
Copy link
Contributor

@vivek vivek commented Jul 29, 2021

Description

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (documentation addition or typo, file relocation)

Testing

  • New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
  • This change requires no testing (i.e. documentation update)

Documentation

  • All added public packages, funcs, and types have been documented with doc comments
  • I have commented my code, particularly in hard-to-understand areas

Final Checklist:

  • I followed standard GitHub flow guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Additional Information (omit if empty)

Please include anything else relevant to this PR that may be useful to know.

stinkyfingers
stinkyfingers approved these changes Jul 29, 2021
View reviewed changes
README.md
curl -s https://raw.githubusercontent.com/shipa-corp/ketch/main/install.sh | bash
```

Alternatively, you can install specific tag at a target location, for example command below installs ketch version v0.4.0 in current directory:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this bit about version and install dir are missing from theketch.io docs. They be useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @stinkyfingers, fixed, https://learn.theketch.io/docs/getting-started#ketch-cli

@vivek vivek merged commit 566c7a2 into main Jul 29, 2021
@vivek vivek deleted the readme-update branch July 29, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinkyfingers stinkyfingers stinkyfingers approved these changes

@brunoa19 brunoa19 Awaiting requested review from brunoa19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vivek @stinkyfingers